Skip to content
Snippets Groups Projects
  1. Feb 04, 2015
    • Bob Lantz's avatar
      Delete both tunnel interfaces · 7c0b56f9
      Bob Lantz authored
      We also clean things up a bit and check for error messages,
      which now can cause exceptions which should invoke cleanup.
      7c0b56f9
    • Bob Lantz's avatar
      node shell: remove unnecessary -m and unset HISTFILE · d90a4551
      Bob Lantz authored
      Since we already disable job notification with +m, it doesn't
      make sense to set it in the original invocation!
      
      It's also annoying if all of the host commands end up overwriting
      your regular bash_history!!
      d90a4551
    • Bob Lantz's avatar
      Change iperf() to use waitListening() · b2fe0778
      Bob Lantz authored
      b2fe0778
    • lantz's avatar
      Merge pull request #474 from mininet/devel/ovsbatch · 3e4f2545
      lantz authored
      Batch startup support for OVS
      
      Currently, every ovs-vsctl command requires reading the entire OVS
      configuration database. This means that its performance gets linearly
      slower as more switches and ports are added. To mitigate this, we
      batch multiple configuration operations into individual, long,
      ovs-vsctl commands.
      
      This patch set makes a couple of other notable changes, including
      setting printPid=False by default (avoids using mnexec unnecessarily)
      and running certain commands using errRun rather than quietRun.
      Additionally we no longer look for leftover links in the root
      namespace, so code relying on that functionality may have to change
      slightly (as in controlnet.py and sshd.py for example.) It also adds
      cluster support to mn -c.
      
      The performance result is that mn --topo linear,200 --test none now
      completes in 60 seconds rather than 95 seconds (on my laptop) without
      the patch (vs. 101 seconds in 2.2.0).
      
      This is still slower than I would like - we should be able to make
      some additional improvements.
      3e4f2545
    • Bob Lantz's avatar
      2e4dd134
    • Bob Lantz's avatar
      use net.addLink() so that link is cleaned up · 19331ca2
      Bob Lantz authored
      19331ca2
    • Bob Lantz's avatar
      9483f637
  2. Jan 29, 2015
    • Bob Lantz's avatar
      Set batch=False in OVSSwitch for low-level API · a4e93368
      Bob Lantz authored
      If you try to use the low-level API, you are probably
      not going to call batchStartup()! So, we set batch=False
      by default. This means that buildFromTopo() needs to set
      it to True, so we add a bit of irritatingly complex machinery
      to allow this to happen. The good fallout of this is that
      now customConstructor() returns a real subclass, not simply
      a constructor function! We also detect errors where people
      are incorrectly attempting to give parameters to a lambda
      function - since none of our lambdas accept parameters!!
      
      Note that this is a bit like functools.partial for classes -
      it would be nice if functools had a true subclassing function.
      a4e93368
    • Bob Lantz's avatar
      c11e9f33
  3. Jan 28, 2015
  4. Jan 27, 2015
    • Bob Lantz's avatar
      Merge OVSBatch into OVSSwitch · bdad3e8c
      Bob Lantz authored
      Note that we are changing the interface of batchStartup/Shutdown
      slightly so that the method can choose not to start some of the
      switches. We might wish to refine this a bit...
      bdad3e8c
  5. Jan 26, 2015
  6. Jan 24, 2015
  7. Jan 22, 2015
    • Bob Lantz's avatar
      Call delete() in link.stop() ; warn on exited node.cmd() · 9db6cdc2
      Bob Lantz authored
      We should think a bit about the semantics that we want here.
      The comments say "stop and clean up link" so perhaps that's
      what we want. However, we could also imagine stop stopping
      forwarding on the link (and possibly allowing restarts).
      
      We warn on exited node.cmd() because we terminate the controller
      before stopping/deleting the links. This makes sense to avoid a
      storm of link/port down events, but since the controller's
      shell has exited we cannot call link.stop() on any of its
      links. We may want to simply stop the controller and not
      terminate it, but at least it doesn't hang for now.
      9db6cdc2
  8. Jan 19, 2015
  9. Jan 17, 2015
  10. Jan 15, 2015
    • Bob Lantz's avatar
      Stub out RemoteOVSSwitch.batchShutdown() · c1b48fb5
      Bob Lantz authored
      Eventually we should implement true batch shutdown.
      In the mean time, we just ignore it. Note there's no good
      way that I know of for a subclass to remove a superclass
      method, so we changed the protocol a bit to require a return
      value of True.
      c1b48fb5
    • Bob Lantz's avatar
      Fix indentation error · b1983548
      Bob Lantz authored
      b1983548
Loading