Shape dimensions

requested review from @pmania

assigned to @naser1

Thanks for the MR! I have the following suggestions:

OBBDimensions shall go into https://gitlab.informatik.uni-bremen.de/robokudo/robokudo/-/blob/main/robokudo/src/robokudo/types/cv.py . It is a rather computer vision centric data type. I would also not use the term 'width/height/depth', since it's a) not obvious which side is which and b) usually hard to detect when just calculating the OBB simply from the perceived sensor data.
OBBDimensions shall be renamed to BoundingBox3D, since this type could also be used for non-oriented BBs.
I gave the Cuboid and Sphere annotation a couple of thoughts and i think they should have a supertype called 'Shape'. This could have two attributes: this.type to describe the actual shape 'cuboid', 'sphere', etc. and self.inliers. The latter is something you already have used. It would allow to avoid this duplication. In general, a RK Type is rather high-level and allows a reasoner for pipeline generation to say something like 'give me an Annotator that yields a Shape with value Cuboid '. Having a super type for all kinds of Shapes would allow to simply reason about anything that has a ShapeAnnotation. For any additional information on the shapes (like radius, center, etc.) , you could then cast to actual Subtype with the details.

I coulld use x,y,z length instead of the current dimensions, which should be unambiguous.
I'll rename it and move it to types/cv.py
I want to make sure, if I understood correctly: You want annotations Sphere and Cuboid to inherit from Shape, where Shape is just a robokudo type? I move the inliers field to Shape and extend that with a field called type

Thank you for the comments

Sounds good!

added 1 commit

dc9048a0 - move OBBDimensions to types/cv and rename to BoundingBox3D and its fields

added 1 commit

Pls take a look into the new commits. Thanks in advance

mentioned in commit c1044c1d

merged

New Annotations: