Tidying

src/freedombone-app-zap

@@ -117,17 +117,21 @@ function reconfigure_zap {
     echo -n ''
 }
 
+function zap_set_permissions {
+    chown -R www-data:www-data "$ZAP_PATH/doc"
+    chown -R www-data:www-data "$ZAP_PATH/store"
+    chmod -R 755 "$ZAP_PATH/store"
+    chmod 1755 "$ZAP_PATH/store/[data]/smarty3"
+    chmod 1755 "$ZAP_PATH/view/tpl"
+    chmod 1755 "$ZAP_PATH/view/tpl/smarty3"
+    chmod 755 "$ZAP_PATH/.htconfig.php"
+}
+
 function upgrade_zap {
     ZAP_PATH=/var/www/$ZAP_DOMAIN_NAME/htdocs
     CURR_ZAP_COMMIT=$(get_completion_param "zap commit")
     if [[ "$CURR_ZAP_COMMIT" == "$ZAP_COMMIT" ]]; then
-        chown -R www-data:www-data "$ZAP_PATH/doc"
-        chown -R www-data:www-data "$ZAP_PATH/store"
-        chmod -R 755 "$ZAP_PATH/store"
-        chmod 1755 "$ZAP_PATH/store/[data]/smarty3"
-        chmod 1755 "$ZAP_PATH/view/tpl"
-        chmod 1755 "$ZAP_PATH/view/tpl/smarty3"
-        chmod 755 "$ZAP_PATH/.htconfig.php"
+        zap_set_permissions
         return
     fi
 
@@ -142,14 +146,7 @@ function upgrade_zap {
 
     chown -R www-data:www-data "$ZAP_PATH/extend"
     ./util/importdoc
-
-    chown -R www-data:www-data "$ZAP_PATH/doc"
-    chown -R www-data:www-data "$ZAP_PATH/store"
-    chmod -R 755 "$ZAP_PATH/store"
-    chmod 1755 "$ZAP_PATH/store/[data]/smarty3"
-    chmod 1755 "$ZAP_PATH/view/tpl"
-    chmod 1755 "$ZAP_PATH/view/tpl/smarty3"
-    chmod 755 "$ZAP_PATH/.htconfig.php"
+    zap_set_permissions
 }
 
 function backup_local_zap {