Skip to content
Snippets Groups Projects
  1. Nov 14, 2012
    • Brandon Heller's avatar
    • Brandon Heller's avatar
      Fix SSHD example by generalizing input intf args · bf208cde
      Brandon Heller authored
      A number of functions in node.py look like this:
         return self.intf( intf ).<other stuff>
      
      Previously, self.intf(...) in Node would expect a string name for an
      interface and return None if an object was passed in instead of a
      string name.
      
      Now, be more permissive and assume that objects passed in are for Intf
      objects.  This makes all such functions in node.py handle more flexible
      input args, either name or actual Intf object.
      
      An alternative and equally valid approach would be to raise an Exception
      whenever a non-string, non-falsy value was passed in to Node.intf(), and
      to modify the code in at least one place - examples/sshd.py - to pass
      the interface name, rather than the interface object.
      
      Also fix input args for examples/scratchnetuser.py - the interface name
      was being passed in as the prefix len, which makes no sense.
      bf208cde
    • Brandon Heller's avatar
      small refactor: put function to ensure root in util · bcfb3009
      Brandon Heller authored
      Two benefits:
      - One place to change if in the future, a more granular method of
        root access is used (like the BigSwitch patch).
      - Makes this reusable by stuff like examples/baresshd.py that use
        the low-level Mininet API.
      bcfb3009
    • Brandon Heller's avatar
      Fix 'cgroups not mounted' error in U12.10 · 8a1264e2
      Brandon Heller authored
      'mount' shows something slightly different in Ubuntu 12.10:
      
      cgroup on /sys/fs/cgroup type tmpfs (rw,uid=0,gid=0,mode=0755)
      
      Note the lack of a plural on first word cgroup, which has changed.
      
      Still mounted at /sys/fs/cgroup, so check for both possibilities
      when instantiated CPU-limited hosts.
      8a1264e2
    • Brandon Heller's avatar
      pep8: Fix E127 continuation line over-indented · 2e089b5e
      Brandon Heller authored
      There are a bunch of these remaining, but I don't think the right course is
      to 'fix' all of them to make pep8 happy, but instead to either change
      the test in pep8 to consider that a continuation line may itself
      be continued halfway, OR, to change the code in these lines to be more
      readable by removing the need for all those nested continuations.
      
      Personally, I find multiply-broken lines (aka nested continuations) really
      hard to read.
      2e089b5e
    • Brandon Heller's avatar
      pep8: fix E128 continuation line under-indented errors · edf60032
      Brandon Heller authored
      I wasn't sure this was worth fixing at first, but it does look more readable
      now.
      edf60032
    • Brandon Heller's avatar
      c0095746
    • Brandon Heller's avatar
  2. Nov 13, 2012
  3. Nov 04, 2012
  4. Oct 31, 2012
  5. Oct 30, 2012
  6. Oct 05, 2012
  7. Sep 15, 2012
  8. Aug 18, 2012
  9. Aug 17, 2012
  10. Aug 06, 2012
  11. Aug 01, 2012
  12. Jul 07, 2012
  13. Jul 04, 2012
  14. Jul 02, 2012
  15. Jun 25, 2012
  16. Jun 05, 2012
  17. May 30, 2012
  18. May 26, 2012
  19. May 24, 2012
  20. May 23, 2012
  21. May 22, 2012
  22. May 17, 2012
  23. May 14, 2012
Loading