Skip to content
Snippets Groups Projects
Select Git revision
  • fif-pep8
  • fix-pep8
  • master default protected
  • docker_build
  • 2.3.0
  • 2.3.0rc2
  • 2.3.0rc1
  • 2.3.0b2
  • 2.3.0b1
  • 2.3.0d6
  • 2.3.0d5
  • 2.3.0d4
  • 2.3.0d3
  • 2.2.2
  • 2.2.1
  • 2.2.0
  • 2.1.0p2
  • 2.1.0p1
  • 2.1.0
  • 2.0.0
  • 1.0.0
  • cs244-spring-2012-final
22 results
Blame Permalink
  • Zi Shen Lim's avatar
    cae7be1a
    mnexec: getopt bugfix · cae7be1a
    Zi Shen Lim authored 
    getopt returns an 'int', so use change datatype of 'c' to match it.
Otherwise, 'c' may hold a value of 255 (0xff), and fail the comparison
with -1 (0xffffffff): while ((c = getopt(...)) != -1)

This bug was uncovered on Ubuntu 13.04 running on ARM, using
arm-linux-gnueabihf-gcc4.7.
    cae7be1a
    History
    mnexec: getopt bugfix
    Zi Shen Lim authored 
    getopt returns an 'int', so use change datatype of 'c' to match it.
Otherwise, 'c' may hold a value of 255 (0xff), and fail the comparison
with -1 (0xffffffff): while ((c = getopt(...)) != -1)

This bug was uncovered on Ubuntu 13.04 running on ARM, using
arm-linux-gnueabihf-gcc4.7.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.